Remove MDF choice, disable tonemapping EDF #2699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distribution was deprecated, GGX by default for every closure. Disable tonemapping by default, so EDF values will be bigger than 1. Remove deprecated (and unused) parameter specular spread (used in student-T MDF).
dictoon
reviewed
Sep 22, 2019
| @@ -87,21 +87,6 @@ shader as_glass | |||
| int gafferNoduleLayoutVisible = 0, | |||
| int divider = 1 | |||
| ]], | |||
| string in_distribution = "ggx" | |||
There was a problem hiding this comment.
To be honest, I hadn't noticed that these parameters were marked as deprecated. That makes them less of a problem than I initially thought.
| @@ -328,26 +312,6 @@ shader as_metal | |||
| return; | |||
| } | |||
|
|
|||
| string distribution; | |||
There was a problem hiding this comment.
That's clearly code that we can remove without breaking anything, regardless of our decision of what to do with the deprecated parameters.
|
In #2688 I've asked what happens to existing Blender scenes. If removing deprecated params don't break them then we can merge this PR as is. Otherwise we'll need to restore the deprecated params. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2688 and #2680