Skip to content

Commit

Permalink
Disable ExistentialAny temporarily (#10)
Browse files Browse the repository at this point in the history
Disable ExistentialAny temporarily

### Motivation

Unfortunately until we adopt 5.9, adding ExistentialAny on upstream packages has unintended consequences for some downstream packages, so disabling for now. Details in apple/swift-openapi-generator#120

### Modifications

Disabled the feature enforcement, but the code changes are there, so downstream adopters can still use them.

### Result

We won't be seeing the issue described in apple/swift-openapi-generator#120.

### Test Plan

PR CI, which discovered the original issue.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#10
  • Loading branch information
czechboy0 committed Jul 17, 2023
1 parent 001c4e9 commit f6e6c2f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ import Foundation
import PackageDescription

// General Swift-settings for all targets.
let swiftSettings: [SwiftSetting] = [
var swiftSettings: [SwiftSetting] = []

#if swift(>=5.9)
swiftSettings.append(
// https://github.com/apple/swift-evolution/blob/main/proposals/0335-existential-any.md
// Require `any` for existential types.
.enableUpcomingFeature("ExistentialAny")
]
)
#endif

let package = Package(
name: "swift-openapi-urlsession",
Expand Down

0 comments on commit f6e6c2f

Please sign in to comment.