Use __attribute__ ((constructor)) instead of INIT_ROUTINE on macOS (Xcode)
#4925
Conversation
…S (Xcode) I'm not sure why but it looks like `__CFInitialize` is not called on macOS with Xcode. ref: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Tasks/InitializingFrameworks.html
|
@swift-ci test |
|
@swift-ci please test macOS platform |
|
Please test with following PRs: @swift-ci please test macOS platform |
|
Static constructors are considered a performance issue on Darwin and are generally avoided. @parkera would this be an acceptable change? Is it even necessary given that corelibs-foundation isn't typically used on Darwin? |
|
It is useful to be able to build and run foundation on macos for testing behavioral issues. I would say that since it didn't normally run in macos, this is likely fine. |
|
I found another solution, using the classic linker by adding Which is better? |
|
CFInitialize simply has to run, and although we don't encourage the use of static initializers in general, we make an exception for this particular one. I think I would rather give it the source code annotation than force a compatibility mode in the linker. |
I'm not sure why but it looks like
__CFInitializeis not called on macOS with Xcode.ref: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Tasks/InitializingFrameworks.html
This might be related to #3271 and #4608.