Fix NSDecimalPower(_:_:_:_:) behavior
#4799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
approved these changes
Jul 26, 2023
compnerd
approved these changes
Jul 26, 2023
|
Either the tests or the implementation need to be updated as this test case fails on CI. |
- rename power to absPower - compare p to 0 and 1, instead of absPower (comparing absPower to 1 results in invalid results) - extract tests for negative power method to external test method - typecast test results to NSDecimalNumber in tests, since by default they were Int
|
@swift-ci test |
|
@swift-ci test windows |
|
@compnerd I'm not seeing this macOS CI failure on PRs that you merged recently. Would you agree that it's sporadic and unrelated to this change and that it can be safely merged? |
|
@MaxDesiatov I think it would be good to understand whats going on though, the macOS build has been somewhat fragile. |
|
@swift-ci please test macOS platform |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
|
@swift-ci test |
MaxDesiatov
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSDecimalPoweracceptsIntaspowerparameter, but internally it callspower(_:roundingMode:)method, that accepts onlyUIntas power value. That results in overflow error for every call ofNSDecimalPowerwith negativepowerparameter.This PR fixes that behavior by modifying
powermethod by makingpan Int and adds additional code for handling negativep.This PR solves #3237