Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directoy ThreadingRunOnUiThread is misnamed - cannot be imported into Eclipse on Windows #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdcheesman
Copy link

The case is incorrect, it should be ThreadingRunOnUIThread (with a capital UI).

@jdcheesman
Copy link
Author

Requires 2 commits to rename due to case handling issues. See Stack Overflow question here: http://stackoverflow.com/questions/3011625/git-mv-and-only-change-case-of-directory

@matthewrpape
Copy link

According to Android coding conventions, acronyms are treated as words and therefore the original "Ui" is correct.

see:
https://source.android.com/source/code-style.html
https://source.android.com/source/code-style.html#treat-acronyms-as-words

@jlslew
Copy link

jlslew commented Feb 19, 2014

@jdcheesman The following is one commit, see the --amend in the last line. This means that they replaced the last commit with a new one. See git-commit(1).
Btw, none of the answers from the SO link ended up with 2 commits.

mv foo foo2
git add -A
git commit -m "renaming"
mv foo2 FOO
git add -A
git commit --amend -m "renamed foo to FOO"

@jdcheesman
Copy link
Author

@jlslew cheers, that's certainly cleaner. I'll check out the link you included. TIL!

@xaevinx OK, have checked out the Android convention and you're 100% correct, it should be Ui. Nonetheless the original problem remains: there is a difference between the application name and the filestructure, and as such the project cannot be imported into Eclipse (at least on Windows).

Given the rest of the examples use "UI" and not "Ui", I suggest my change is more consistent - unless the other examples are changed too I think the use of Ui could easily lead to confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants