-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic validations for @source
#5141
Conversation
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I left a few comments around nits (and possible a bug?) but feel free to ignore!
Co-authored-by: Nicholas Cioli <nicholas.cioli@apollographql.com>
…dylan/validate-connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot to hit submit on these comments last week, some of this might be outdated/redundant, sorry!
# Conflicts: # apollo-federation/src/sources/connect/mod.rs
Thank you both—suggestions applied! |
A first crack at validations for
@source
. This new code is really only designed to be consumed in@apollo/federation-internals
via WASM—and there's a working prototype of that here.