Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic validations for @source #5141

Merged
merged 13 commits into from May 13, 2024
Merged

Conversation

dylan-apollo
Copy link
Member

A first crack at validations for @source. This new code is really only designed to be consumed in @apollo/federation-internals via WASM—and there's a working prototype of that here.

@router-perf
Copy link

router-perf bot commented May 10, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@dylan-apollo dylan-apollo changed the title Dylan/validate connectors Basic validations for @source May 10, 2024
Copy link
Contributor

@nicholascioli nicholascioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I left a few comments around nits (and possible a bug?) but feel free to ignore!

Copy link
Contributor

@lennyburdette lennyburdette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot to hit submit on these comments last week, some of this might be outdated/redundant, sorry!

@dylan-apollo
Copy link
Member Author

Thank you both—suggestions applied!

@dylan-apollo dylan-apollo merged commit d8571b9 into connectors May 13, 2024
10 of 12 checks passed
@dylan-apollo dylan-apollo deleted the dylan/validate-connectors branch May 13, 2024 19:01
@dylan-apollo dylan-apollo restored the dylan/validate-connectors branch May 13, 2024 19:01
@dylan-apollo dylan-apollo deleted the dylan/validate-connectors branch May 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants