Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip dashes from trace_id in CustomTraceIdPropagator #5071

Conversation

kindermax
Copy link
Contributor

When trace_id taken from headers it can be a uuid4 with dashes and opentelemetry::trace::TraceId::from_hex will not parse this in proper TraceId

Fixes #4892

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

When trace_id taken from headers it can be a uuid4 with dashes and `opentelemetry::trace::TraceId::from_hex` will not parse this in proper `TraceId`
@apollo-cla
Copy link

@kindermax: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@router-perf
Copy link

router-perf bot commented May 3, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@BrynCooke
Copy link
Contributor

@kindermax just pinging to remind you that we can't merge this until the CLA is signed: #5071 (comment)
Otherwise it looks looks good to me.

@kindermax
Copy link
Contributor Author

@BrynCooke huh, that's strange, since I've already signed the CLA. I've signed it one more time just in case (received a letter) and GH action says CLA — Author has signed the Apollo CLA.. Am I doing it correctly ?

@BrynCooke
Copy link
Contributor

@kindermax Strange, usually the bot comes along with a comment to say that things are OK. I'll check if there's anything going on.

@kindermax
Copy link
Contributor Author

kindermax commented May 8, 2024

@BrynCooke, is there anything I can do to help merge this PR ? I see some failing checks like arm_linux_test and NEXT_CHANGELOG.md reminder but I do not know what to do with it.

@smyrick
Copy link
Member

smyrick commented May 9, 2024

@kindermax You can create a change set to describe your feature for the changelog following the docs here: https://github.com/apollographql/router/tree/dev/.changesets

@BrynCooke
Copy link
Contributor

Yeah I think we just need a changeset and then we're good to go.

@kindermax
Copy link
Contributor Author

Changeset added.

@kindermax
Copy link
Contributor Author

I see some failing tests but I'm not sure if it is related to this PR (but I could be wrong)

@BrynCooke
Copy link
Contributor

@kindermax Yes there is something weird going on with router bridge and CI right now. Don't worry I'lll make sure we merge this before the next release of the router.

@bnjjj bnjjj merged commit 51242fa into apollographql:dev May 13, 2024
12 of 13 checks passed
@kindermax
Copy link
Contributor Author

Just wanted to say thank you since it is my first rust contribution, and you guys were very supportive. ❤️

@kindermax kindermax deleted the strip-dashes-from-trace-id-in-CustomTraceIdPropagator branch May 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header added to request in rhai does not propagated into logs trace_id field
5 participants