-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip dashes from trace_id in CustomTraceIdPropagator #5071
Strip dashes from trace_id in CustomTraceIdPropagator #5071
Conversation
When trace_id taken from headers it can be a uuid4 with dashes and `opentelemetry::trace::TraceId::from_hex` will not parse this in proper `TraceId`
@kindermax: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
CI performance tests
|
@kindermax just pinging to remind you that we can't merge this until the CLA is signed: #5071 (comment) |
@BrynCooke huh, that's strange, since I've already signed the CLA. I've signed it one more time just in case (received a letter) and GH action says |
@kindermax Strange, usually the bot comes along with a comment to say that things are OK. I'll check if there's anything going on. |
@BrynCooke, is there anything I can do to help merge this PR ? I see some failing checks like |
@kindermax You can create a change set to describe your feature for the changelog following the docs here: https://github.com/apollographql/router/tree/dev/.changesets |
Yeah I think we just need a changeset and then we're good to go. |
Changeset added. |
I see some failing tests but I'm not sure if it is related to this PR (but I could be wrong) |
@kindermax Yes there is something weird going on with router bridge and CI right now. Don't worry I'lll make sure we merge this before the next release of the router. |
Just wanted to say thank you since it is my first rust contribution, and you guys were very supportive. ❤️ |
When trace_id taken from headers it can be a uuid4 with dashes and
opentelemetry::trace::TraceId::from_hex
will not parse this in properTraceId
Fixes #4892
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.