chore(deps): update dependency moment to v2.29.4 [security] (version-3)

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
moment (source)	2.29.3 -> 2.29.4

GitHub Vulnerability Alerts

CVE-2022-31129

Impact

• using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
• noticeable slowdown is observed with inputs above 10k characters
• users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

---

Release Notes

moment/moment (moment)

v2.29.4

Compare Source

• Release Jul 6, 2022
  • #​6015 [bugfix] Fix ReDoS in preprocessRFC2822 regex

---

Configuration

📅 Schedule: Branch creation - "" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @apollo/federation@0.27.0
npm ERR! notsup Not compatible with your version of node/npm: @apollo/federation@0.27.0
npm ERR! notsup Required: {"node":">=12.13.0 <17.0"}
npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v18.16.0"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/worker/1e47f4/c7c6ee/cache/others/npm/_logs/2023-04-17T11_49_15_140Z-debug-0.log

[changeset-bot]

⚠️ No Changeset found

Latest commit: 30ea2fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.