fix：初始加载失败依旧加入懒加载列表，异步检查流程优化 #309
Conversation
|
Warning Rate Limit Exceeded@qdsordinarydream has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 30 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on enhancing robustness and reliability across various components. Changes include better handling of Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
protocol/http/request.go (1)
Line range hint
74-76: Consider specifyingMinVersion: tls.VersionTLS13in the TLS configuration to ensure that only secure TLS versions are used. This enhances security, especially for public-facing applications.- InsecureSkipVerify: insecureSkipVerify, + InsecureSkipVerify: insecureSkipVerify, MinVersion: tls.VersionTLS13
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- client.go (2 hunks)
- client_test.go (1 hunks)
- component/remote/async.go (1 hunks)
- protocol/http/request.go (1 hunks)
Additional comments not posted (5)
component/remote/async.go (1)
86-88: The addition of a condition to check ifapolloConfig.Configurationsis not empty before updating notifications is a good practice. It prevents unnecessary updates and potential errors when there are no configurations to process.protocol/http/request.go (1)
216-221: The addition of a condition to check the node length before setting a node down in single-node scenarios is a crucial improvement. It prevents erroneous behavior in systems with minimal node setups and enhances the robustness of the network error handling.client.go (2)
167-168: Logging a warning whenapolloConfigisnilis a good practice as it provides visibility into potential issues during configuration synchronization.
193-198: Updating the notification ID to-1whenapolloConfigis not present is a critical fix that ensures the system can handle initial load failures more gracefully by allowing for retries or appropriate handling later.client_test.go (1)
415-415: Adding an assertion to check theGetNotifymethod of theNotificationsMapfor a specific return value in theTestGetConfigAndInitValNilfunction is a good practice. It ensures that the method behaves as expected when queried with a non-existent key, enhancing the test coverage and robustness of the new error handling logic.
Pull Request Test Coverage Report for Build 9042914117Details
💛 - Coveralls |
初始加载失败依旧加入懒加载列表
检查到存在通知，需要判断返回的结构做没有值的容错，在异步流程中，没有值的返回是异常的，应该在请求的时候就报错了
request 函数中，当只有一个节点可用的时候，直接返回，不然会造成客户端最多异常20min（等待下一次服务列表同步）
Summary by CodeRabbit
Bug Fixes
Tests