Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1025-use-dto-to-pass-data-around #745

Draft
wants to merge 22 commits into
base: 12.x
Choose a base branch
from

Conversation

Mohammad-Alavi
Copy link
Member

@Mohammad-Alavi Mohammad-Alavi commented Feb 10, 2024

Description

#709

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: Patch coverage is 93.15068% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.52%. Comparing base (0a2f840) to head (263a117).

Files Patch % Lines
app/Containers/AppSection/User/Models/User.php 0.00% 2 Missing ⚠️
...ction/User/UI/API/Requests/AbstractUserRequest.php 0.00% 2 Missing ⚠️
...rs/AppSection/User/Data/Resources/UserResource.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               12.x     #745      +/-   ##
============================================
- Coverage     89.95%   89.52%   -0.44%     
- Complexity      393      396       +3     
============================================
  Files           184      186       +2     
  Lines          1185     1184       -1     
============================================
- Hits           1066     1060       -6     
- Misses          119      124       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant