feat(validator): parameter validation #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
parameter-validator
branch
from
22782dd
to
1f573d0
Compare
vincentchalamon
requested changes
Apr 21, 2024
src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
Outdated
Show resolved
Hide resolved
soyuka
force-pushed
the
parameter-validator
branch
7 times, most recently
from
38c54d6
to
2f3e56f
Compare
dunglas
reviewed
Apr 29, 2024
src/Metadata/Parameter.php
Outdated
| /** | ||
| * @return Constraint|Constraint[]|null | ||
| */ | ||
| public function getConstraints(): array|Constraint|null |
There was a problem hiding this comment.
Suggested change
| public function getConstraints(): array|Constraint|null | |
| public function getConstraints(): Constraint|array|null |
Nit: for consistency with the type of the property.
src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php
Show resolved
Hide resolved
dunglas
approved these changes
Apr 29, 2024
soyuka
force-pushed
the
parameter-validator
branch
from
2f3e56f
to
5125873
Compare
soyuka
force-pushed
the
parameter-validator
branch
from
5125873
to
35bbb96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constraint to parameters to allow validation: