Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add compatibility with doctrine/orm 3.0 #6156

Closed
wants to merge 2 commits into from

Conversation

ddeboer
Copy link
Contributor

@ddeboer ddeboer commented Feb 12, 2024

Q A
Branch? main
Tickets Closes #6199
License MIT
Doc PR

Introduce compatibility with doctrine/orm 3.0.

@soyuka
Copy link
Member

soyuka commented Feb 12, 2024

nice! can you run the doctrine orm component tests? Also it looks like phpstan isn't happy

Copy link

@stevan-tosic stevan-tosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine from my side but phpstan only to be resolved :)

@ddeboer
Copy link
Contributor Author

ddeboer commented Feb 15, 2024

Solved some problems, but others are popping up. Is there any documentation on how to run the tests and checks locally?

@soyuka
Copy link
Member

soyuka commented Feb 16, 2024

Hi, thanks for the patch, I guess that our lowest tests would fail not having the new ClassMetadata? Still a bunch of red jobs though. Yes the documentation is at:
https://github.com/api-platform/core/blob/main/CONTRIBUTING.md#tests

@soyuka
Copy link
Member

soyuka commented Mar 1, 2024

waiting for symfony/symfony@ac07f3e

@fabpot
Copy link

fabpot commented Mar 1, 2024

@soyuka You need this commit in a release? If yes, which branch do you need (5.4, 6.4, 7.0, the three of them)?

@soyuka
Copy link
Member

soyuka commented Mar 1, 2024

@fabpot yes 6.4 and 7.0 would be great but I'd like to be sure it's the only blocker

@soyuka
Copy link
Member

soyuka commented Mar 1, 2024

Thanks @ddeboer fo starting this went on my branch to continue as gh actions was buggy

@ddeboer ddeboer deleted the doctrine-orm-3 branch March 2, 2024 18:32
@ddeboer
Copy link
Contributor Author

ddeboer commented Mar 2, 2024

My pleasure @soyuka. Thank you for wrapping this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctrine ORM 3 support
4 participants