Fix issues with extending {XML,Yaml} -> {XML,Yaml} resources #5956
Conversation
senghe
changed the title
senghe
force-pushed
the
hotfix/fix-extending-resources-3.2
branch
2 times, most recently
from
cbae89d
to
9773872
Compare
senghe
force-pushed
the
hotfix/fix-extending-resources-3.2
branch
from
9773872
to
aea2f42
Compare
|
I see one build run has been cancelled - the red one. Could you rerun it? 🙏 |
| @@ -75,14 +75,15 @@ private function buildResources(array $resourcesYaml, string $path): void | |||
| $resourceYaml = [$resourceYaml]; | |||
| } | |||
|
|
|||
| $resourcesCount = isset($this->resources[$resourceName]) ? \count($this->resources[$resourceName]) : 0; | |||
| foreach ($resourceYaml as $key => $resourceYamlDatum) { | |||
There was a problem hiding this comment.
is key always an int @vincentchalamon ?
There was a problem hiding this comment.
Hmmm not sure that it's always an int, cf. https://github.com/api-platform/core/blob/main/src/Metadata/Tests/Extractor/yaml/valid.yaml
To be sure, it would be better to rely on an int variable declared out of this foreach and incremented accordingly.
|
this looks nice, can you target 3.1? We should add a test somehow |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi, to be honest I'm not so familiar with API Platform dev structure, so I think I'm not able to add tests here. But in a free time I'll check whether the index is always integer - as it was discussed above and refactor this. |
Hi all! :) I was testing a feature of extending resources by multiple XML/Yaml resource files for the same resource. For XMLs it works from scratch, but there is two issues:
It looks for me as a bug, because as you can see, there is too little changes from me to solve it.
Please let me know, what is your opinion regarding to this topic 🖖