Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variable to disable highlight attributes #128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FlorianeEnnaji
Copy link

Hello!
I added a variable called forceNoHighlightAttributes to disable the highlighting of the string found in each item. It also prevents the workaround advised in #34 or #67.
I'm happy to discuss this.

@apasccon
Copy link
Owner

Hey @FlorianeEnnaji!, I really appreciate your suggestion!.

In my opinion would be better this behavior:

  • If you set the theme manually, then the library shall apply the same font size to the highlighted attributes by default (I guess this is the more common situation)
  • If you just want to avoid highlighting attributes, you can always set this attributes the same as the theme's font attributes

What do you think about it?

@FlorianeEnnaji
Copy link
Author

@apasccon Is that what you were thinking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants