ZOOKEEPER-2623: Forbid OpCode.check outside OpCode.multi #2105
+157
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
from
d70640e
to
93ee6a8
Compare
Individual `OpCode.check` will get `UnimplementedException`.
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
from
93ee6a8
to
3b24226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
OpCode.checkwill getUnimplementedException.This is backport of #2104 without commits from #1988 so to make it clean for reviewing.