Doc: storage.yaml #11000
Draft
Doc: storage.yaml #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alan M. Carroll <amc@apache.org>
masaori335
commented
Feb 9, 2024
masaori335
commented
Feb 9, 2024
masaori335
commented
Feb 14, 2024
|
|
||
| cache: # file level key | ||
| spans: # | ||
| - id: # identifier / name of the span |
There was a problem hiding this comment.
This is very bike-shedding, but calling this name is better than id?
There was a problem hiding this comment.
Probably better and you can differentiate it from volume:id, which is a different object I know but a fast reader can confuse.
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for discuss details of making
volume.configandstorage.configinto one YAML file.Most of the docs were written by @SolidWallOfCode last year and I made some changes from his draft.
Differences are
storage.yamlinstead ofcache.yamlinteger, because it's referred fromhosting.config( we can change itstringlater, but I'd like to leave it as is for now )span[].sizeI'll open another PR for implementation.