Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5776: Cpp cross test fail test #2968

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

THRIFT-5776: Cpp cross test fail test #2968

wants to merge 2 commits into from

Conversation

CJCombrink
Copy link
Contributor

@CJCombrink CJCombrink commented Apr 27, 2024 •
edited

THRIFT-5776

  • Not yet sure where the issue might be
  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from da9310f to d01ceb8 Compare April 28, 2024 19:32
@developStorm developStorm mentioned this pull request Apr 30, 2024
Merged
MaoZiming pushed a commit to Trinity-data-store/Trinity that referenced this pull request Apr 30, 2024
@developStorm
Fix Node Setup Script (#1)
3f0409d 
* fix: include flex and bison in dependency setup script

* fix: space missing for thrift installation block

* fix: add pkgconf in setup script

* refactor: switch to a stable release of thrift

main stream seems to have a bug that prevents compilation at this time apache/thrift#2968
@Jens-G
Copy link
Member

Jens-G commented May 1, 2024

Still draft?

@CJCombrink
Copy link
Contributor Author

@Jens-G I still need to look into the latest errors as mentioned on the ticket.
However when I was testing this was sufficient to to get the build/docker/scripts/autotools.sh script to pass, but the OP seems to have more issues.

@CJCombrink
Fist stab at trying to get behind the error
3f708a7 
- Not yet sure where the issue might be
@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from 5ebbe73 to 3f708a7 Compare May 6, 2024 19:11
@CJCombrink
Copy link
Contributor Author

@Jens-G Sorry for the delay, I am looking into this this week, I could not over the weekend.

@CJCombrink
Fix the compiler issues
1eaf6e1 
- Define the functions
- Cross test of UUID not implemented
@CJCombrink CJCombrink marked this pull request as ready for review May 7, 2024 05:18
@CJCombrink
Copy link
Contributor Author

@Jens-G The last commits at least fixes the compile errors in the 'ubuntu-jammy' docker containers as well.
I have not implemented any cross tests, just made it compile.
I can look at better cross tests but would like to get some feedback on THRIFT-5773 so that I can do the work there.

After these changes I now also get THRIFT-5775 as per the original ticket tracking this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ testsuite
Projects
None yet
Milestone
No milestone
2 participants
@CJCombrink @Jens-G