Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4551. Upgrade commons-io to 2.16.0. #344

Merged
merged 2 commits into from May 6, 2024

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Apr 3, 2024

JIRA: TEZ-4551. Upgrade commons-io to 2.16.0.

We are currently using commons-io version 2.8.0, which is an older version (Sep 09, 2020). Commons-io has been upgraded to 2.16.0 (Mar 28, 2024). We can try to upgrade the version to 2.16.0.

@tez-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

slfan1989 commented Apr 4, 2024

@abstractdog @ayushtkn Can you help review this pr? Thank you very much!

The error reported in the unit test is not caused by this pr.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 25m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 14m 58s master passed
+1 💚 compile 2m 23s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 compile 2m 10s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javadoc 1m 32s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 8s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 💚 mvninstall 4m 30s the patch passed
+1 💚 compile 2m 26s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javac 2m 26s the patch passed
+1 💚 compile 2m 11s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javac 2m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 8s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 ❌ unit 46m 43s root in the patch failed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
107m 24s
Reason Tests
Failed junit tests tez.test.TestDAGRecovery
tez.test.TestRecovery
tez.test.TestAMRecovery
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-344/2/artifact/out/Dockerfile
GITHUB PR #344
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux de33186feb09 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 906059a
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-344/2/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-344/2/testReport/
Max. process+thread count 2090 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-344/2/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

failing unit tests are because of TEZ-4559, this looks good to me

@abstractdog abstractdog self-requested a review May 6, 2024 07:47
@abstractdog abstractdog merged commit 3925544 into apache:master May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants