TEZ-4540: Reading proto data more than 2GB from multiple splits fails #334
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
zabetak
reviewed
Feb 5, 2024
Comment on lines
99
to
101
| if (din.in != in) { | ||
| cin.resetSizeCounter(); | ||
| } |
There was a problem hiding this comment.
The javadoc of CodedInputStream#setSizeLimit says the following:
If you want to read several messages from a single CodedInputStream, you could call resetSizeCounter() after each one to avoid hitting the size limit.
Based on that I would be inclined to reset the counter after every single message otherwise it still seems feasible to hit the same error if the DataInput is sufficiently large.
There was a problem hiding this comment.
Thanks for the review @zabetak.
I missed this Java doc statement. I was suspecting that resetting the totalBytesRetired after every message read might have unexpected impact therefore, I resetted it after every hdfs split read. But based on the Javadoc, I think we can reset the counter after every mesage read. Will modify the patch.
Thanks.
Aggarwal-Raghav
force-pushed
the
proto
branch
from
4090cbc
to
e3a247c
Compare
|
💔 -1 overall
This message was automatically generated. |
zabetak
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM, thanks for pushing this forward @Aggarwal-Raghav ! My approval is not binding so you will have to ping a Tez committer to merge this.
|
@abstractdog @harishjp. Can you please help get this in tez 0.10.3 |
thanks @Aggarwal-Raghav for the patch, let me check soon |
|
CodedInputStream.totalBytesRetired can be easily checked by CodedInputStream.getTotalBytesRead(), so can you include a unit test that reads at least twice with ProtoMessageWritable and validates that cin.resetSizeCounter() was indeed called? |
Have added a basic UT for checking cin.resetSizeCounter() is called. |
|
🎊 +1 overall
This message was automatically generated. |
|
@abstractdog, can you please help with the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to this: HIVE-28026 and apache/hive#5033