Skip to content

Commit

Permalink
[SPARK-48226][BUILD] Add spark-ganglia-lgpl to lint-java & `spark…
Browse files Browse the repository at this point in the history
…-ganglia-lgpl` and `jvm-profiler` to `sbt-checkstyle`

### What changes were proposed in this pull request?
The pr aims to add
- `spark-ganglia-lgpl` to `lint-java`
- `spark-ganglia-lgpl` and `jvm-profiler` to `sbt-checkstyle`

### Why are the changes needed?
1.Because the module `spark-ganglia-lgpl` has `java` code
2.Because the module `spark-ganglia-lgpl` & `jvm-profiler` has `scala` code
3.Although these module codes currently comply with the specification, in order to avoid problems like #46376, they will occur again in future modifications.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
- Manually test.
- Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #46501 from panbingkun/minor_spark-ganglia-lgpl.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
panbingkun authored and dongjoon-hyun committed May 9, 2024
1 parent b47d785 commit e704b9e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dev/lint-java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"

ERRORS=$($SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pkubernetes -Pyarn -Phive -Phive-thriftserver checkstyle:check | grep ERROR)
ERRORS=$($SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pspark-ganglia-lgpl -Pkubernetes -Pyarn -Phive -Phive-thriftserver checkstyle:check | grep ERROR)

if test ! -z "$ERRORS"; then
echo -e "Checkstyle checks failed at following occurrences:\n$ERRORS"
Expand Down
2 changes: 1 addition & 1 deletion dev/sbt-checkstyle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# limitations under the License.
#

SPARK_PROFILES=${1:-"-Pkinesis-asl -Pkubernetes -Pyarn -Phive -Phive-thriftserver"}
SPARK_PROFILES=${1:-"-Pkinesis-asl -Pspark-ganglia-lgpl -Pkubernetes -Pyarn -Phive -Phive-thriftserver -Pjvm-profiler"}

# NOTE: echo "q" is needed because SBT prompts the user for input on encountering a build file
# with failure (either resolution or compilation); the "q" makes SBT quit.
Expand Down

0 comments on commit e704b9e

Please sign in to comment.