SOLR-15045: DistributedZkUpdateProcessor should issue commits to local shards and remote shards in parallel #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commits in DistributedZkUpdateProcessor
NOTE: this test jumps through hoops to support "failure" expressed as success, for compatibility with the way distrib shard commit errors are (not) currently propagated back to the client. This behavior is likely a bug in its own right that should be addressed separately, probably before this fix is committed
…lel-cloud-commits
…lel-cloud-commits
…lel-cloud-commits
it was jumping through hoops to try to recreate superficial aspects of the initial problem, but for no real purpose, and at the expense of much additional complexity.
…lel-cloud-commits
let this change bake on main, per @dsmiley's suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: SOLR-15045
Continued from Lucene/Solr PR #2449