Refactor AlterSQLFederationRuleExecutorTest Test Case #31138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Mysql create loadable function returns int/dec * apply spotless * Add final for CreateLoadableFunctionTestCase
* Add enum process on RepositoryTupleSwapperEngine * Add enum process on RepositoryTupleSwapperEngine
… value and field name (apache#31155)
… value and field name (apache#31157)
* Splitting YamlSingleTableRuleConfiguration tuple * Fix checkstyle * Fix unit test
* Refactor RepositoryTupleEntity * Merge RepositoryTupleType and RepositoryTupleEntity * Merge RepositoryTupleType and RepositoryTupleEntity
|
Hi @terrymanu, I hope you're doing well. I wanted to follow up on this MR. Are the changes acceptable, or do I need to make further enhancements? Thank you! |
* Add EncryptRule.getAllTableNames() * Add EncryptRule.getAllTableNames()
* Remove useless events * Remove useless events
…pache#31162) * Add PartialRuleUpdateSupported feature and try in encrypt rule first * Add PartialRuleUpdateSupported feature and try in encrypt rule first
* Reuse encryptors when update encrypt tables * Fix sonar issues
* fix miss column segment from cast and convert function * fix miss column segment from cast and convert function
…utorTest' into 30083-AlterSQLFederationRuleExecutorTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #30083.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.