Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests for ShardingMetaDataReviseEntry #30765

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Unit Tests for ShardingMetaDataReviseEntry #30765

merged 1 commit into from
Apr 6, 2024

Conversation

shubham-j-sde
Copy link
Contributor

@shubham-j-sde shubham-j-sde commented Apr 3, 2024 •
edited

Fixes #28532 .

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@shubham-j-sde
Copy link
Contributor Author

Hey @tuichenchuxin , can you plx help with review.
Thanks!

@tuichenchuxin tuichenchuxin added this to the 5.5.0 milestone Apr 6, 2024
@tuichenchuxin tuichenchuxin merged commit c28a306 into apache:master Apr 6, 2024
18 checks passed
@shubham-j-sde shubham-j-sde deleted the issue28532 branch April 16, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuichenchuxin tuichenchuxin tuichenchuxin approved these changes

Assignees
No one assigned
Labels
in: test type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add more unit tests for ShardingMetaDataReviseEntry
2 participants
@shubham-j-sde @tuichenchuxin