Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EncryptColumnNameReviser.java #28701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update EncryptColumnNameReviser.java #28701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
79 changes: 62 additions & 17 deletions ...a/org/apache/shardingsphere/encrypt/metadata/reviser/column/EncryptColumnNameReviser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,72 @@
* limitations under the License.
*/

// package org.apache.shardingsphere.encrypt.metadata.reviser.column;

// import org.apache.shardingsphere.encrypt.rule.EncryptTable;
// import org.apache.shardingsphere.infra.metadata.database.schema.reviser.column.ColumnNameReviser;

// /**
// * Encrypt column name reviser.
// */
// public final class EncryptColumnNameReviser implements ColumnNameReviser {

// private final EncryptTable encryptTable;

// public EncryptColumnNameReviser(final EncryptTable encryptTable) {
// this.encryptTable = encryptTable;
// }

// @Override
// public String revise(final String originalName) {
// if (encryptTable.isCipherColumn(originalName)) {
// return encryptTable.getLogicColumnByCipherColumn(originalName);
// }
// return originalName;
// }
// }

package org.apache.shardingsphere.encrypt.metadata.reviser.column;

import org.apache.shardingsphere.encrypt.rule.EncryptTable;
import org.apache.shardingsphere.infra.metadata.database.schema.reviser.column.ColumnNameReviser;
import org.junit.Before;
import org.junit.Test;

/**
* Encrypt column name reviser.
*/
public final class EncryptColumnNameReviser implements ColumnNameReviser {

private final EncryptTable encryptTable;

public EncryptColumnNameReviser(final EncryptTable encryptTable) {
this.encryptTable = encryptTable;
import java.util.Arrays;
import java.util.Collections;

import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class EncryptColumnNameReviserTest {

private EncryptColumnNameReviser encryptColumnNameReviser;

@Before
public void setUp() {
EncryptTable encryptTable = mock(EncryptTable.class);
when(encryptTable.getLogicColumnByPlainColumn("plain_column")).thenReturn("logic_column");
when(encryptTable.getLogicColumnByCipherColumn("cipher_column")).thenReturn("logic_column");
when(encryptTable.isCipherColumn("cipher_column")).thenReturn(true);
when(encryptTable.getPlainColumns()).thenReturn(Collections.singletonList("plain_column"));
encryptColumnNameReviser = new EncryptColumnNameReviser(encryptTable);
}

@Test
public void assertRevisePlainColumn() {
assertThat(encryptColumnNameReviser.revise("plain_column"), is("logic_column"));
}

@Test
public void assertReviseCipherColumn() {
assertThat(encryptColumnNameReviser.revise("cipher_column"), is("logic_column"));
}

@Override
public String revise(final String originalName) {
if (encryptTable.isCipherColumn(originalName)) {
return encryptTable.getLogicColumnByCipherColumn(originalName);
}
return originalName;

@Test
public void assertReviseOtherColumn() {
assertThat(encryptColumnNameReviser.revise("other_column"), is("other_column"));
}
}
}