Rename SelectStatementContext#isSameGroupByAndOrderByItems to isGroupByStartsWithOrderByItems(#25414) #25680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull new code
…ByStartsWithOrderByItems(apache#25414)
strongduanmu
requested changes
May 19, 2023
| @@ -294,8 +296,20 @@ private String getOrderItemText(final TextOrderByItemSegment orderByItemSegment) | |||
| * | |||
| * @return group by and order by sequence is same or not | |||
| */ | |||
| public boolean isSameGroupByAndOrderByItems() { | |||
| return !groupByContext.getItems().isEmpty() && groupByContext.getItems().equals(orderByContext.getItems()); | |||
| public boolean isGroupByStartsWithOrderByItems() { | |||
There was a problem hiding this comment.
Hi @yangsen00, can you add e2e test for this logic change?
There was a problem hiding this comment.
Of course.but Can you give a Can you give an example？
There was a problem hiding this comment.
…ByStartsWithOrderByItems(apache#25414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename SelectStatementContext#isSameGroupByAndOrderByItems to isGroupByStartsWithOrderByItems(#25414 )