Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing failure when solving left join associated query. Change hashset to linkedHashSet #25194

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lmandy
Copy link

@lmandy lmandy commented Apr 17, 2023

I have changed the Hashset to LinkedHashSet, This mysql #25170

@lmandy lmandy closed this Apr 18, 2023
@lmandy lmandy reopened this Apr 18, 2023
@lmandy
Copy link
Author

lmandy commented Apr 20, 2023

CI failed, as fllows
image
Please deal with this pr

@strongduanmu
Copy link
Member

Hi @lmandy, thank you for your contribution. Can you add unit test for this logic?

@lmandy
Copy link
Author

lmandy commented May 4, 2023

Ok, which module should I add? Is there an example for reference?

@github-actions github-actions bot added the stale label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants