Support SQL non-parsing, transparent transmission mode #25180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrymanu
requested changes
Apr 17, 2023
| @@ -34,4 +34,6 @@ public final class SQLParserRuleConfiguration implements GlobalRuleConfiguration | |||
| private final CacheOption parseTreeCache; | |||
|
|
|||
| private final CacheOption sqlStatementCache; | |||
|
|
|||
| private final String engineType; | |||
There was a problem hiding this comment.
Please add default value for engineType. It is better to add a compatible constructor.
| @@ -40,7 +40,7 @@ public SQLParserRuleConfiguration buildAlteredRuleConfiguration(final SQLParserR | |||
| CacheOption sqlStatementCache = | |||
| null == sqlStatement.getSqlStatementCache() ? currentRuleConfig.getSqlStatementCache() | |||
| : createCacheOption(currentRuleConfig.getSqlStatementCache(), sqlStatement.getSqlStatementCache()); | |||
| return new SQLParserRuleConfiguration(sqlCommentParseEnabled, parseTreeCache, sqlStatementCache); | |||
| return new SQLParserRuleConfiguration(sqlCommentParseEnabled, parseTreeCache, sqlStatementCache, "Standard"); | |||
There was a problem hiding this comment.
Please add // TODO with reason to reminder it fix in future
| /** | ||
| * Simple SQL statement. | ||
| */ | ||
| public final class SimpleSQLStatement implements SQLStatement { | ||
| public final class SimpleSQLStatement implements MySQLStatement { |
There was a problem hiding this comment.
How about rename it as MySQLSimpleSQLStatement and create real SimpleSQLStatement?
|
Since this pr has long time no response, I will close it now. You are welcome to submit a new PR and modify the comment issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.