Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] Supports creating tokens with additional headers #22690

Merged
merged 4 commits into from May 20, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented May 10, 2024

Motivation

Currently, the tool that generates the token cannot attach headers. We should support it. For example, it makes sense to attach a kid field for JWKS.

Modifications

Supports creating tokens with additional headers

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 10, 2024
@coderzc coderzc requested a review from nodece May 10, 2024 11:04
@nodece nodece added this to the 3.4.0 milestone May 10, 2024
@nodece
Copy link
Member

nodece commented May 10, 2024

/pulsarbot rerun-failure-checks

@Technoboy-
Copy link
Contributor

@lhotari @heesung-sn Could you help take a look ?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (bbc6224) to head (aef7cfc).
Report is 281 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22690      +/-   ##
============================================
- Coverage     73.57%   73.16%   -0.41%     
- Complexity    32624    32849     +225     
============================================
  Files          1877     1889      +12     
  Lines        139502   141401    +1899     
  Branches      15299    15517     +218     
============================================
+ Hits         102638   103457     +819     
- Misses        28908    29937    +1029     
- Partials       7956     8007      +51     
Flag Coverage Δ
inttests 27.43% <0.00%> (+2.85%) ⬆️
systests 24.75% <0.00%> (+0.42%) ⬆️
unittests 72.15% <100.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ar/broker/authentication/utils/AuthTokenUtils.java 77.27% <100.00%> (+1.08%) ⬆️
...pache/pulsar/utils/auth/tokens/TokensCliUtils.java 39.28% <100.00%> (+11.42%) ⬆️

... and 371 files with indirect coverage changes

@coderzc coderzc merged commit 9c60134 into apache:master May 20, 2024
50 checks passed
@coderzc coderzc added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants