Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][offload] Allow to disable the managedLedgerOffloadDeletionLagInMillis #22689

Merged
merged 2 commits into from May 16, 2024

Conversation

zymap
Copy link
Member

@zymap zymap commented May 10, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #22688

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Copy link

@zymap Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Technoboy- Technoboy- added this to the 3.4.0 milestone May 13, 2024
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 15, 2024
@dao-jun
Copy link
Member

dao-jun commented May 15, 2024

close reopen to trigger the ci checks

@dao-jun dao-jun closed this May 15, 2024
@dao-jun dao-jun reopened this May 15, 2024
@Technoboy- Technoboy- changed the title [WIP][improve] Allow to disable the managedLedgerOffloadDeletionLagInMillis [improve][offload] Allow to disable the managedLedgerOffloadDeletionLagInMillis May 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (bbc6224) to head (a02e514).
Report is 270 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22689      +/-   ##
============================================
- Coverage     73.57%   73.14%   -0.43%     
- Complexity    32624    32839     +215     
============================================
  Files          1877     1889      +12     
  Lines        139502   141393    +1891     
  Branches      15299    15517     +218     
============================================
+ Hits         102638   103423     +785     
- Misses        28908    29977    +1069     
- Partials       7956     7993      +37     
Flag Coverage Δ
inttests 27.41% <0.00%> (+2.83%) ⬆️
systests 24.75% <0.00%> (+0.43%) ⬆️
unittests 72.16% <100.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 81.00% <100.00%> (+0.34%) ⬆️

... and 359 files with indirect coverage changes

@dao-jun dao-jun merged commit 73fd61d into apache:master May 16, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test release/3.3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants