Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] Trigger offload on topic load #22652

Merged

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: PIP-348

Motivation

Implement of PIP-348

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 6, 2024
@hangc0276 hangc0276 self-assigned this May 6, 2024
@hangc0276 hangc0276 added area/tieredstorage category/functionality Some functions are not working such as get errors release/3.2.3 and removed doc-not-needed Your PR changes do not impact docs labels May 6, 2024
@hangc0276 hangc0276 added this to the 3.3.0 milestone May 6, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 6, 2024
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@dao-jun
Copy link
Member

dao-jun commented May 16, 2024

close reopen to trigger ci workflow

@dao-jun dao-jun closed this May 16, 2024
@dao-jun dao-jun reopened this May 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.57%. Comparing base (bbc6224) to head (580a422).
Report is 273 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22652      +/-   ##
============================================
- Coverage     73.57%   70.57%   -3.00%     
+ Complexity    32624    32224     -400     
============================================
  Files          1877     1890      +13     
  Lines        139502   150413   +10911     
  Branches      15299    17744    +2445     
============================================
+ Hits         102638   106157    +3519     
- Misses        28908    35867    +6959     
- Partials       7956     8389     +433     
Flag Coverage Δ
inttests 29.14% <80.00%> (+4.56%) ⬆️
systests 24.65% <75.00%> (+0.33%) ⬆️
unittests 70.74% <80.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...apache/bookkeeper/mledger/ManagedLedgerConfig.java 96.38% <100.00%> (+0.08%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 98.49% <100.00%> (-0.90%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 69.97% <100.00%> (-10.81%) ⬇️
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 70.23% <50.00%> (-10.43%) ⬇️
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 80.51% <0.00%> (-0.88%) ⬇️

... and 405 files with indirect coverage changes

@dao-jun dao-jun merged commit 400a286 into apache:master May 17, 2024
99 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tieredstorage category/functionality Some functions are not working such as get errors cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants