Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker][WIP] Add brokerId to lookup results and load manager data #22647

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 3, 2024

WIP: This PR most likely requires a PIP and that will follow.

Motivation

In the past brokers didn't have a stable unique identifier. In PR #21894, the "lookupServiceAddress" was renamed to be "brokerId" so that there would be a single unique identifier for a broker in a cluster.

This PR continues making brokerId a first class identifier for a broker. The long term benefit is having consistency across the APIs. One reason to add this information to the topic lookup result is to be able to use the APIs in a way where you lookup a topic and receive that broker id. With this broker id, you could then lookup more details about the broker in the Admin API with the broker id.

Modifications

  • add brokerId to lookup results
  • add brokerId to load manager data
    • brokerId already was contained in LoadReport with the field name name instead of brokerId. Keep the name name for backwards compatibility
  • add client test to ensure that lookup result includes the broker id for both binary and http lookup results

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone May 3, 2024
@lhotari lhotari self-assigned this May 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 3, 2024
@lhotari lhotari marked this pull request as draft May 3, 2024 17:33
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants