Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ml]Fix subscription props could be lost in case of missing ledger during recovery #22637

Merged
merged 1 commit into from May 20, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented May 2, 2024

Motivation

During the recovery of the cursor, if the stored position points to a non existent ledger, the cursor is rewinded to the oldest position. In this case the subscription properties won't be stored in the managedcursor info on the metadata store

Modifications

  • Pass the cursorProperties instead of an empty map during recovery

Verifying this change

  • Make sure that the change passes the CI checks.

  • doc-not-needed

Copy link

github-actions bot commented May 2, 2024

@nicoloboschi Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 2, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone May 8, 2024
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@nicoloboschi nicoloboschi requested review from lhotari, codelipenghui and eolivelli and removed request for lhotari and codelipenghui May 20, 2024 14:12
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dao-jun dao-jun merged commit b5bc390 into apache:master May 20, 2024
57 of 60 checks passed
@Technoboy- Technoboy- changed the title [fix][ml]: subscription props could be lost in case of missing ledger during recovery [fix][ml]Fix subscription props could be lost in case of missing ledger during recovery May 21, 2024
Technoboy- pushed a commit that referenced this pull request May 21, 2024
Technoboy- pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants