New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side #22577
base: master
Are you sure you want to change the base?
Conversation
I think we intentionally overlooked the result of creating a topic for the remote cluster. This PR may break the user's behavior of creating topic. According to your description, when using the default broker configuration, and the geo-replication is enabled on the namespace level, the remote cluster will create two non-partitioned topics, tenant/namespace/topic-partition-1 and tenant/namespace/topic-partition-2 by the geo producer. Is it right? If right, I would suggest adding a topic check before starting the replicator to make sure that the topic is the same between local and remote clusters, if they are the same, start the replicator, otherwise throw a log. You can also add this check in the replicator task. |
a60407e
to
0e13f60
Compare
Rebase master |
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Show resolved
Hide resolved
…there is a confilct topic on the remote side
0e13f60
to
d0963b6
Compare
Rebase master |
Motivation
The steps to describe the issue
1
. And the source cluster does not have this topic.3
partitions on the source cluster.Modifications
Reject a topic creation if there is a conflict topic on the remote side
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x