[improve][pip] PIP-347: Add role field in consumer's stat #22562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
|
PTAL, thanks. @lhotari @codelipenghui @BewareMyPower @Technoboy- @dao-jun @poorbarcode |
BewareMyPower
requested review from
lhotari,
Technoboy-,
codelipenghui and
BewareMyPower
BewareMyPower
previously requested changes
Apr 23, 2024
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ConsumerStats.java
Outdated
Show resolved
Hide resolved
15 tasks
thetumbled
changed the title
dao-jun
approved these changes
May 14, 2024
|
@thetumbled Please resolve conflicts |
thetumbled
force-pushed
the
AddRoleForConsumerStat2
branch
from
95453f3
to
677ed2f
Compare
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Done, thank you. |
|
Could you help to review? thank you. @lhotari @Technoboy- @codelipenghui |
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
May 16, 2024
Technoboy-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By setting config
allowAutoSubscriptionCreation=true, we allow user to create subscriptions automatically if user have theconsumepermission.We have a strong need to trace back the owner of a specific subscription, but currently there is no such way to achieve that.
Modifications
Add field
appIdin the stats response, which contains role info when cluster use JWT.Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#48