Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] PIP-188 Support blue-green migration #1210

Merged
merged 9 commits into from
Jun 5, 2024
Merged

[feat] PIP-188 Support blue-green migration #1210

merged 9 commits into from
Jun 5, 2024

Conversation

heesung-sn
Copy link
Contributor

Master Issue: apache/pulsar#16551

Motivation

  • Support blue-green migration pip-188 for golang client

Modifications

  • added blue-green client logic
  • register the producer instance in the producers map before sending produce creation command. This is required since broker could send topic migration command in the middle of creating the producer.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@heesung-sn heesung-sn requested review from RobertIndie, wolfstudy and shibd and removed request for RobertIndie and wolfstudy May 5, 2024 16:02
RobertIndie
RobertIndie reviewed May 23, 2024
View reviewed changes
pulsar/internal/connection.go Outdated Show resolved Hide resolved
pulsar/internal/connection.go Show resolved Hide resolved
@heesung-sn
Copy link
Contributor Author

@RobertIndie Hi could you check this again?

@RobertIndie RobertIndie merged commit 6876346 into apache:master Jun 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@shibd shibd Awaiting requested review from shibd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heesung-sn @RobertIndie