Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1191][Consumer] allow override the Schema Creator by a consumer #1192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adrianiacobghiula
Copy link

@adrianiacobghiula adrianiacobghiula commented Mar 1, 2024

a consumer might want to use different implementation of a Schema

Motivation

A consumer should be allowed to select / choose / override the default Schema. For example select to use https://github.com/hamba/avro and not github.com/linkedin/goavro/v2

Modifications

Add options to

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? GoDocs

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing a new option would introduce complexity to the ConsumerOptions.
We could start a discussion to replace https://github.com/linkedin/goavro with https://github.com/hamba/avro. Could you share more motivation on this?
Would you like to initiate this discussion on the mailing list?

@adrianiacobghiula
Copy link
Author

I agree it increases complexity :) On the other hand it offers the consumer/client the possibility to access all schema versions basically & create Schema for each of them.
Yes. I would initiate a discussion on the mailing list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants