Optimise Sorting in SegmentProcessorFramework [WIP] #13091
Draft
+231
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create the sort order only using the sort columns. Currently we mmap the whole data file and compare fucntion causes thrashing if the dataset is too large. * We just load the sort columns and create the sort order using only that comparisons.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13091 +/- ##
=============================================
- Coverage 61.75% 27.75% -34.00%
+ Complexity 207 192 -15
=============================================
Files 2436 2507 +71
Lines 133233 137864 +4631
Branches 20636 21345 +709
=============================================
- Hits 82274 38266 -44008
- Misses 44911 96687 +51776
+ Partials 6048 2911 -3137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load only the sort columns in memory and call compare on the loaded columns instead of calling compare on the whole memory mapped datafile.