Upgrade jna to version 5.14.0 for Mac M1/M2 local execution support #13018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pom.xml
Outdated
| @@ -1459,7 +1459,7 @@ | |||
| <dependency> | |||
| <groupId>net.java.dev.jna</groupId> | |||
| <artifactId>jna</artifactId> | |||
| <version>5.5.0</version> | |||
| <version>5.7.0</version> | |||
There was a problem hiding this comment.
Seems the latest version is 5.14.0. Should we try to upgrade to the latest one?
There was a problem hiding this comment.
Sure, let me update the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13018 +/- ##
============================================
+ Coverage 61.75% 62.18% +0.43%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136671 +3438
Branches 20636 21164 +528
============================================
+ Hits 82274 84986 +2712
- Misses 44911 45397 +486
- Partials 6048 6288 +240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhioncbr
changed the title
Jackie-Jiang
approved these changes
Apr 29, 2024
Jackie-Jiang
approved these changes
Apr 29, 2024
| @@ -67,12 +67,12 @@ | |||
| <dependency> | |||
| <groupId>net.java.dev.jna</groupId> | |||
| <artifactId>jna-platform</artifactId> | |||
There was a problem hiding this comment.
Consider moving this to the root pom
| @@ -67,12 +67,12 @@ | |||
| <dependency> | |||
| <groupId>net.java.dev.jna</groupId> | |||
| <artifactId>jna-platform</artifactId> | |||
| <version>5.14.0</version> | |||
| <version>${jna.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>net.java.dev.jna</groupId> | |||
| <artifactId>jna</artifactId> | |||
There was a problem hiding this comment.
This override shouldn't be needed
| @@ -45,6 +45,12 @@ | |||
| <groupId>com.azure</groupId> | |||
| <artifactId>azure-identity</artifactId> | |||
| <version>1.12.0</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
Do we need this exclusion? It should just pull the correct version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm raising this PR to understand the conversation on Slack regarding the JNA upgrade.
Some tests fail on Mac M1/M2-based chips because of the
jnaloading issue. As per the StackOverflow solutions,jna 5.7.0has fixes for the loading issue. I updated thejnaand got the test cases running locally.