Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fix and improvements on SchemaConformingTransformerV2 #12932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lnbest0707-uber
Copy link
Contributor

tags: feature bugfix
Followup from PR #12788 with:

  • Getter/setter fix on SchemaConformingTransformerV2Config
  • Schema and config validation improvement
  • String type single value field ser/deser improvement
  • Column - JsonKeyPath mapping improvement
  • Unit test improvement with more comprehensive case coverage

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 62.21%. Comparing base (59551e4) to head (1e097f1).
Report is 302 commits behind head on master.

Files Patch % Lines
...cordtransformer/SchemaConformingTransformerV2.java 50.00% 9 Missing and 3 partials ⚠️
...ingestion/SchemaConformingTransformerV2Config.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12932      +/-   ##
============================================
+ Coverage     61.75%   62.21%   +0.46%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2503      +67     
  Lines        133233   136517    +3284     
  Branches      20636    21125     +489     
============================================
+ Hits          82274    84933    +2659     
- Misses        44911    45310     +399     
- Partials       6048     6274     +226     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.17% <40.00%> (+0.46%) ⬆️
java-21 62.09% <40.00%> (+0.47%) ⬆️
skip-bytebuffers-false 62.19% <40.00%> (+0.44%) ⬆️
skip-bytebuffers-true 62.07% <40.00%> (+34.34%) ⬆️
temurin 62.21% <40.00%> (+0.46%) ⬆️
unittests 62.20% <40.00%> (+0.46%) ⬆️
unittests1 46.69% <0.00%> (-0.20%) ⬇️
unittests2 28.00% <40.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants