Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for multiple values of a key in a Config file - apache#9102, apache#12689 #12799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepthi912
Copy link
Contributor

@deepthi912 deepthi912 commented Apr 5, 2024

Fix #9102 #12689

Overriding the existing values with the last value in the list instead of adding them as a list of values in the Config File.

After Fix: controller.data.dir is taken as the last value.

fix

…ration values are taken as a list of values.

Overriding the existing values with the last value in the list.
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause problem for real array values. I think the core problem is that there is no way to differentiate key with single value vs array

@xiangfu0
Copy link
Contributor

xiangfu0 commented Apr 5, 2024

This will cause problem for real array values. I think the core problem is that there is no way to differentiate key with single value vs array

I didn't recall that there is an explicitly method to merge duplicate keys into one comma separated array.

Is this really used somewhere or possibly we can error it out? Feeling it's causing more confusion than the convenient.

@deepthi912
Copy link
Contributor Author

deepthi912 commented Apr 5, 2024

@Jackie-Jiang Yes, this fix was made assuming there wouldn't be an array of values for a key in a config file. However since there can be such scenarios, it is difficult to differentiate between real array values and multiple keys in a config when set through different sources. Only if Apache Configuration makes some upgrade removing the existing behaviour, this could be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the instance config, entries with same key are treated as array which can cause unexpected behavior
3 participants