NUTCH-3044 Generator: NPE when extracting the host part of a URL fails #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewismc
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
+1 LGTM
I was thinking we could provide a TestGenerator#testNullHostInReducer test case which would bootstrap the SelectorReducer.reduce with some "well formed" and "not well-formed" URLs in order to validate that no NPE is thrown. The test case should fail before your patch is applied and pass afterwards.
- add unit test to proof that URLs without a host part do not cause errors
Good idea! Done, see 4729786. |
- replace deprecated method call - improve and format Javadoc
sebastian-nagel
force-pushed
the
NUTCH-3044-generator-npe
branch
from
4c7aa71
to
b153279
Compare
|
... also fixed the Javadoc error. |
|
Excellent @sebastian-nagel +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.