Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUTCH-1870 XSL parse filter #439

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

NUTCH-1870 XSL parse filter #439

wants to merge 1 commit into from

Conversation

sebastian-nagel
Copy link
Contributor

  • apply patch contributed by @albinscode
  • load configuration files from classpath and address thread-safety

Note: not ready yet:

  • TODOs in code
  • unit tests fail (with DOM built by tagsoup parser)
  • see also open points in NUTCH-1870

@sebastian-nagel
NUTCH-1870 XSL parse filter
c4c059b 
- apply patch contributed by @albinscode
- load configuration files from classpath
- address thread-safety
@balashashanka
Copy link
Contributor

Hi @sebastian-nagel, was going through this. Out of curiosity why hasn't this still merged?
I see in the discussions everyone is ok with the code. And it doesnt have any merge conflicts.

@sebastian-nagel
Copy link
Contributor Author

See the TODOs in the comment here and Jira.

@sebastian-nagel sebastian-nagel marked this pull request as draft September 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sebastian-nagel @balashashanka