Feature: Support to ask user for authorization #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjanc Please TAL |
andrzej-kaczmarek
requested changes
Dec 29, 2023
SumeetSingh19
force-pushed
the
feat/gatt_authorization
branch
from
841645f
to
50eac03
Compare
|
@sjanc PTAL |
|
@Singh-Sumeet we discussed with @sjanc and we agreed that return value from callback should be used instead of event struct field. we'd also like to have an option in future to make it authorization asynchronous so the return values should be reject, accept, pending - please add appropriate macros for that. reject should be set to 0 so authorization is rejected by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to add: