nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID when encryption is enabled without distributing IRK. #1620
Conversation
…ption is enabled without distributing IRK and hence controller has no IRK but host has LTK. If address resolution is enabled in the controller it will reject any RL modification during scanning, adv, etc. Hence controller sends a Command disallowed error which needs to be sent back to the application. Also when encryption is enabled without distributing IRK and hence the controller has no IRK but the host has LTK then the controller will return error 0x202 which needs not to be returned to delete LTK. (Hence it is skipped to return when the error code is 0 or 0x202.)
There was a problem hiding this comment.
code looks OK but could you make commit message match convention?
commit message and topic should fit in 72 lines (if possible)
topic : "nimble/host:Handled error return value BLE_ERR_UNK_CONN_ID"
and then commit message (new lines at <72 chars)
"When encryption is enabled without distributing IRK and hence controller
has no IRK but host has LTK. If address resolution is enabled in the
controller it will reject any RL ......"
This is mainly for keeping 'git log' consitent
|
Sure.Thanks for this suggestion. I will follow commit conventions and change the commit message. |
| @@ -6062,6 +6063,9 @@ ble_gap_unpair(const ble_addr_t *peer_addr) | |||
|
|
|||
| ble_hs_pvcy_remove_entry(peer_addr->type, | |||
There was a problem hiding this comment.
looks like return value from ble_hs_pvcy_remove_entry() is never stored in rc...
There was a problem hiding this comment.
Thanks for your suggestion. So I have made further changes including above mentioned in this API and will update this PR.
If address resolution is enabled in the controller it will reject any RL modification during scanning, adv, etc. Hence controller sends a Command disallowed error which needs to be sent back to the application. Also when encryption is enabled without distributing IRK and hence the controller has no IRK but the host has LTK then the controller will return error 0x202 which needs not to be returned to delete LTK. (Hence it is skipped to return when the error code is 0 or 0x202.)