Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBUILDCACHE-87] - Checksum should consider plugin dependencies #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reda-alaoui
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@AlexanderAshitkin
Copy link
Contributor

AlexanderAshitkin commented Apr 25, 2024

In addition to the test created, it will be nice to cover the logic with tests more cases:

  • External plugin dependency of a snapshot version is also accounted for in the checksum.
  • Dependencies present both as a project dependency and a plugin dependency are counted twice (adding a plugin dependency in addition to an existing project dependency changes the checksum) and vice versa

@AlexanderAshitkin
Copy link
Contributor

AlexanderAshitkin commented Apr 25, 2024

The increased entropy could be a potential vector of regression. Though the feature looks legit and should be on by default, there should be a way to turn it off if it doesn't work as expected. Please add a configuration flag to turn it off. Ideally, it should be a per-plugin flag.

@reda-alaoui reda-alaoui marked this pull request as draft May 17, 2024 16:36
@reda-alaoui reda-alaoui force-pushed the MBUILDCACHE-87 branch 13 times, most recently from 14e470e to df667ae Compare May 19, 2024 17:02
@reda-alaoui reda-alaoui marked this pull request as ready for review May 19, 2024 17:03
@reda-alaoui reda-alaoui marked this pull request as draft May 19, 2024 17:03
@reda-alaoui reda-alaoui marked this pull request as ready for review May 19, 2024 17:08
@reda-alaoui
Copy link
Member Author

Oups, I forgot to add logs.

@reda-alaoui reda-alaoui marked this pull request as draft May 19, 2024 17:21
@reda-alaoui reda-alaoui marked this pull request as ready for review May 29, 2024 16:13
@reda-alaoui
Copy link
Member Author

@AlexanderAshitkin can you take a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants