Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bulkclose feature to the githubPRs script #2625

Draft
wants to merge 1 commit into
base: branch_8_11
Choose a base branch
from

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Dec 8, 2021

Example use:

./githubPRs.py \
  --bulkclose "Lucene and Solr development has moved to separate git repositories and this PR is being bulk-closed. Please open a new PR against https://github.com/apache/solr or https://github.com/apache/lucene if your contribution is still relevant to the project." \
  --token XXXXXXXXXXXXX

Result of such an action can be seen in #1364 which I used for testing. You can then easily query GitHub for a list of the stale-closed PRs: https://github.com/apache/lucene-solr/pulls?q=label%3Astale-closed+is%3Aclosed

@rmuir
Copy link
Member

rmuir commented Dec 8, 2021

-1 to adding bulk close functionality

@rmuir
Copy link
Member

rmuir commented Dec 8, 2021

That's an actual veto. justification: read the fucking mailing list thread, see how @janhoy tried to "slip this in" under the pretense of a +1. Several of us are against bulk-closing on the thread. It is more people, than are for it. Consensus is not with you. Passive-aggressive shit like this doesn't help.

@janhoy janhoy marked this pull request as draft December 10, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants