Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FlushIndexTask to flush documents at index thread level. #2349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added FlushIndexTask to flush documents at index thread level. #2349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293eee1
Added FlushIndexTask to flush data at index thread level.
balmukundblr Feb 10, 2021
1a5c86d
Removed commented code.Also, changed the num of thread to 8 to work w…
balmukundblr Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lucene/benchmark/conf/indexing-flush-by-RAM-multithreaded.alg
View file
Open in desktop
Expand Up @@ -53,7 +53,8 @@ log.queries=true

{ "Populate"
CreateIndex
[{ "MAddDocs" AddDoc } : 5000] : 4
#[{ "MAddDocs" AddDoc } : 5000] : 4
[{ {{"MAddDocs" AddDoc } : 5000} FlushIndex } ] : 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 1) remove the old (commented out) line entirely? And 2), 20 threads seems a bit much for a "typical" box now? Maybe go to 8 instead?

Hmm, it would be nice if benchmarks made the local machine's CPU concurrency available (Runtime.getRuntime().availableProcessors()) so we could set this dynamically. But that is for another day!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sure Mike, we will remove the old (commented out) line entirely.
  2. We can change #parallel indexing thread to 8, to work with a typical box.

ForceMerge(1)
CloseIndex
}
Expand Down
37 changes: 37 additions & 0 deletions lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/FlushIndexTask.java
View file
Open in desktop
@@ -0,0 +1,37 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.lucene.benchmark.byTask.tasks;

import org.apache.lucene.benchmark.byTask.PerfRunData;
import org.apache.lucene.index.IndexWriter;

/** Flush Index Task uses flushNextBuffer() to flush documents at thread level */
public class FlushIndexTask extends PerfTask {

public FlushIndexTask(PerfRunData runData) {
super(runData);
}

@Override
public int doLogic() throws Exception {
IndexWriter iw = getRunData().getIndexWriter();
if (iw != null) {
iw.flushNextBuffer();
}
return 1;
}
}