scriptis left database menu bar supports hiveserver2 to get library table fields #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFengqin
changed the title
peacewong
reviewed
Sep 21, 2023
| import com.fasterxml.jackson.databind.node.ArrayNode; | ||
| import com.fasterxml.jackson.databind.node.ObjectNode; | ||
|
|
||
| /** @author Qin* */ |
There was a problem hiding this comment.
need to remove author info
...asource/linkis-metadata/src/main/java/org/apache/linkis/metadata/util/HiveService2Utils.java
Outdated
Show resolved
Hide resolved
| if (StringUtils.isNotBlank(hiveServer2Username)) { | ||
| username = hiveServer2Username; | ||
| } | ||
| conn = DriverManager.getConnection(url, username, hiveServer2Password); |
There was a problem hiding this comment.
Need to use connection pool?
|
|
||
| private static final String defaultDb = "default"; | ||
| private static Connection conn = null; | ||
| private static Statement stat = null; |
There was a problem hiding this comment.
It should not be defined as a property, otherwise there will be concurrency problems
GuoPhilipse
reviewed
Sep 21, 2023
|
|
||
| import org.apache.commons.lang.StringUtils; | ||
|
|
||
| import java.sql.*; |
There was a problem hiding this comment.
It's better not to import * ,just import the necessary ones.
GuoPhilipse
reviewed
Sep 21, 2023
|
|
||
| import java.sql.*; | ||
| import java.text.SimpleDateFormat; | ||
| import java.util.*; |
casionone
reviewed
Sep 22, 2023
| private static final String driverName = "org.apache.hive.jdbc.HiveDriver"; | ||
|
|
||
| private static final String defaultDb = "default"; | ||
| private static final String defaultPassword = "123456"; |
There was a problem hiding this comment.
need to be set defaultPassword ?
|
Please handle the third dependency check problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The left database menu bar of scriptis supports hiveserver2 to get library table fields, which is off by default
Related parameters:
To enable this function, you need to add the following configuration in the linkis-ps-publicservice. properties file
Enable hiveserver2 access: linkis.hive.server2.enable=true
Configuration hiveserver2 address: linkis.hive.server2.address=jdbc:hive2://127.0.0.1:10000/