Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of Sonar code scanning #4369

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

binbinCheng
Copy link
Contributor

@binbinCheng binbinCheng commented Mar 15, 2023

What is the purpose of the change

Fix the problem of Sonar code scanning

企业微信截图_16788450596968

Related issues/PRs

Related issues: #4360
Related pr:#4369

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

jacktao007
jacktao007 previously approved these changes Apr 12, 2023
Copy link
Contributor

@jacktao007 jacktao007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong changed the base branch from dev-1.4.0 to master June 20, 2023 09:39
@peacewong peacewong dismissed jacktao007’s stale review June 20, 2023 09:39

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants