Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6353] Catch exception for closing flink internal session #6354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wForget
Copy link
Member

@wForget wForget commented Apr 30, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6353

Describe Your Solution 🔧

Catch exception for closing flink internal session.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@wForget wForget self-assigned this Apr 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.45%. Comparing base (c73ae71) to head (32fc9af).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6354   +/-   ##
=========================================
  Coverage     58.45%   58.45%           
  Complexity       24       24           
=========================================
  Files           653      653           
  Lines         39880    39880           
  Branches       5481     5481           
=========================================
+ Hits          23311    23312    +1     
- Misses        14071    14074    +3     
+ Partials       2498     2494    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Failure to close session will result in flink engine not exiting
2 participants